[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Note latent bug in libsvn_wc/diff.c

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-10-08 17:47:53 CEST

On Fri, 7 Oct 2005, Malcolm Rowe wrote:

> I've just spotted what I'm almost certain is a bug in libsvn_wc/diff.c,
> and I'd like to make sure it's not forgotten.
>
> So why not add a regression test? The precise bug is that svn_client_diff3()
> will, for wc->repos diffs, report deleted directories as adds. However,
> BASE<->repos diffs don't currently report deleted directories at all
> (that's another bug), and there's no way to get the command-line client
> to request a WORKING->repos diff, only a repos->WORKING diff (which in
> this situation, produces identical - but this time, correct - output).
>
I see. It might be possible to use the binding tests for this, but I no
nothing about them. Is the reason you're not fixing the bug that you can't
test it or is it hard to fix in itself?

BTW, I think we need real libsvn_client tests for stuff like this and
stuff like thi diff_summarize APIs that aren't available through the
cmdline client (yet).

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 8 17:50:08 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.