[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix confusing comments introduced in r16476

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-10-07 02:16:36 CEST

Hi Peter,

I'm really not trying to pick on your commit, honest! But this one had
me confused for ages; please consider applying.

Part of the commit for r16476 re-wrapped a call to
svn__client_get_diff_editor(), but in doing so it made the end-of-line
comments look like they applied to the following arguments. I've just
spent a while trying to work out why we bother opening a second RA
session, if it "doesn't matter for diff". Please fix, for my sanity,
if nothing else!

[[[
* subversion/libsvn_client/diff.c
  (diff_repos_repos): Make it clear which argument the comments refer to.
]]]

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Oct 7 02:17:10 2005

This is an archived mail posted to the Subversion Dev mailing list.