Re: pre-revprop-change hook problems

Malcolm Rowe wrote:
>
> I would have thought the current (intended) behaviour was correct -
> we're calling the hook with a blank 3rd argument. Unfortunately, I'm
> guessing that apr_proc_create can't run a (program? batch file? only on
> Windows?) with a blank argument, which is causing the other arguments
> to shift into that position.

That's right, as Philip has since pointed out.

> Is anything else (other than the author field in hook scripts, that is)
> likely to be affected by this problem?

No, it is not likely. I have just checked. Apart from hook scripts, the only
other uses of this APR function for running a program are in "svn diff" and
"svn merge" with external diff/diff3 programs. As far as I can tell there are
currently no cases that could attempt to pass an empty argument to them when
using the "svn" command-line client.

It is possible that another client of the libraries could run into this problem
by passing an empty option to svn_client_diff3() or an empty label to
svn_wc_merge().

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 7 00:41:07 2005