[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_wc/status.c:assemble_status() doc string lies?

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-10-05 01:03:54 CEST

On Tue, 04 Oct 2005, Philip Martin wrote:

> kfogel@collab.net writes:
...
> > A bit verbose, maybe just:
> >
> > + non-versioned thing. If non-null, ENTRY's lifetime is
> > + unimportant, as it will be deep-copied into *STATUS.
>
> I'd just drop all mention of the pool lifetime, documenting that it is
> "unimportant" is a bit silly. Don't mention the deep-copy either,
> it's an implementation detail. In general if functions don't mention
> lifetime then it should be safe to assume that the parameters doesn't
> need to live beyond the function call.

Thanks guys, removed in r16466.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 5 01:03:12 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.