[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16428 - in trunk/subversion: clients/cmdline libsvn_ra_local tests/clients/cmdline/svntest

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-10-05 00:26:34 CEST

Peter N. Lundblad wrote:
> On Mon, 3 Oct 2005 maxb@tigris.org wrote:
>
>> Modified: trunk/subversion/clients/cmdline/main.c
>> Url:
>> http://svn.collab.net/viewcvs/svn/trunk/subversion/clients/cmdline/main.c?rev=16428&p1=trunk/subversion/clients/cmdline/main.c&p2=trunk/subversion/clients/cmdline/main.c&r1=16427&r2=16428
>> ==============================================================================
>> --- trunk/subversion/clients/cmdline/main.c (original) +++
>> trunk/subversion/clients/cmdline/main.c Mon Oct 3 13:55:14 2005
>> @@ -845,7
>> +845,7 @@ if (err)
>> return svn_cmdline_handle_exit_error (err, pool, "svn: ");
>>
>> -#ifdef WIN32
>> +#if defined(WIN32) || defined(__CYGWIN__)
>
> I'm wondering if we should introduce an own macro for this. If we need to
> do something special on Windows, it seems easy to forget about __CYGWIN__
> (yes, I use Cygwin sometimes...:-)

I don't think we should, because not every WIN32 case is also good for
Cygwin. So I think we should leave things as is, and only add an explicit
__CYGWIN__ when required.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 5 00:27:28 2005

This is an archived mail posted to the Subversion Dev mailing list.