[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_fs_* make use of functions declared in _private_ libsvn_delta header

From: <kfogel_at_collab.net>
Date: 2005-10-04 21:45:13 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> On Tue, 2005-10-04 at 14:31 -0500, kfogel@collab.net wrote:
> > Because (b) is simpler to explain and remember.
>
> Functions with double underscores aren't part of the public API. How
> hard is that to explain and remember?

It's very easy, it's just incomplete. A programmer would read that
and think it's okay to use some library's double-underscore functions
*anywhere* in Subversion, not just in that library. That's not what
we want, is it?

   "Symbols with double-underscores should only be used inside the
    library where they are defined. E.g., svn_foo__bar_baz(), should
    only be used inside libsvn_foo."

That's always been my understanding of the double-underscore
convention, and I think it's a good principle. The API provided by
libsvn_foo should treat other Subversion libraries the same way it
treats non-Subversion callers. If "clean" and "modular" mean
anything, don't they mean this?

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 4 22:54:35 2005

This is an archived mail posted to the Subversion Dev mailing list.