[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_wc/status.c:assemble_status() doc string lies?

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-10-04 22:02:28 CEST

On Tue, 04 Oct 2005, Daniel Rall wrote:
...
> However, it appears to do a deep copy of entry:
>
> stat->entry = svn_wc_entry_dup (entry, pool);
>
> From svn_wc.h:
>
> /** Return a duplicate of @a entry, allocated in @a pool. No part of the new
> * entry will be shared with @a entry.
> */
> svn_wc_entry_t *svn_wc_entry_dup (const svn_wc_entry_t *entry,
> apr_pool_t *pool);
...

* subversion/libsvn_wc/status.c
  (assemble_status): Correct doc string describing the handling of the
   ENTRY parameter and the lifetime of its pool.

--- status.c (revision 16464)
+++ status.c (working copy)
@@ -190,11 +190,10 @@
 
    ENTRY may be null, for non-versioned entities. In this case, we
    will assemble a special status structure item which implies a
- non-versioned thing.
+ non-versioned thing. As non-null ENTRY will be deep copied (as
+ opposed to stored directly), and the lifetime its pool is not
+ important.
 
- Else, ENTRY's pool must not be shorter-lived than STATUS's, since
- ENTRY will be stored directly, not copied.
-
    PARENT_ENTRY is the entry for the parent directory of PATH, it may be
    NULL if ENTRY is NULL or if PATH is a working copy root. The lifetime
    of PARENT_ENTRY's pool is not important.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 4 22:01:56 2005

This is an archived mail posted to the Subversion Dev mailing list.