libsvn_wc/status.c:assemble_status() doc string lies?

assemble_status() produces a svn_wc_status2_t. Part of its input for
assembly of that structure is a svn_wc_entry_t. About that entry, it
claims:

   ENTRY may be null, for non-versioned entities. In this case, we
   will assemble a special status structure item which implies a
   non-versioned thing.

   Else, ENTRY's pool must not be shorter-lived than STATUS's, since
   ENTRY will be stored directly, not copied. <==== *

However, it appears to do a deep copy of entry:

  stat->entry = svn_wc_entry_dup (entry, pool);

From svn_wc.h:

/** Return a duplicate of @a entry, allocated in @a pool. No part of the new
 * entry will be shared with @a entry.
 */
svn_wc_entry_t *svn_wc_entry_dup (const svn_wc_entry_t *entry,
                                  apr_pool_t *pool);

It seems that it is then a lie that we care about the lifetime of entry's
pool?

- Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 4 21:07:02 2005