[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Python bindings svn_wc_entry() is broken

From: David James <james82_at_gmail.com>
Date: 2005-10-04 17:07:41 CEST

On 10/4/05, Max Bowsher <maxb@ukf.net> wrote:
> >>> svn.wc.entry('nonexistentpath', aa, False)
> <libsvn.core.GenericSWIGWrapper instance at 0x5d820c>
>
> The problem is with functions that deliberately return a NULL pointer to
> signify "does not exist".
> The correct Python translation of this would be None, but the bindings are
> incorrectly returning an internal wrapper object. This is bad, because any
> code making any real use of svn_wc_entry will be testing the return value
> either for truth or None-ness in order to tell whether the entry was found,
> and this will break that.
Good catch, Max! This should be fixed in r16450.

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 4 17:09:06 2005

This is an archived mail posted to the Subversion Dev mailing list.