[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] V3, diff summarize (preview) without text deltas

From: Martin Hauner <martin.hauner_at_gmx.net>
Date: 2005-10-03 17:44:21 CEST

Peter N. Lundblad wrote:
> On Sun, 2 Oct 2005, Martin Hauner wrote:
>
>
>>attached is the third version of the diff summarize api call that doesn't
>>produce text deltas (which helps to build a nice diff interface in a gui
>>client or at least that's why i did write it :) This is also partially
>>issue #2015 (without -v).
>>
>>I have fixed/updated it based on Peter Lundblads nice review and cleaned
>>up a few other things.
>>
>
> Thanks for those kind words:-) Just FYI, I'm in the process of applying
> this patch, since it looks very good overall. There are small style nits
> here and there, which I'm fixing as I go through the patch.

Cool, thanks :)

> I'm doing one
> larger change, though. INstead of one kind field and two boolean fields in
> svn_client_diff_summarize_t, I'm combining item and text "status" into one
> filed as we do in the status APIs. I think that's more intuitive.

Funny, i have changed it in this patch to use two booleans instead of one
thinking this might be easier to understand. ;) But it was a bit strange
to use from my gui client. So i guess combining item and text status again
is the better solution.

-- 
Martin
Subcommander, http://subcommander.tigris.org
a cross platform Win32/Unix/MacOSX subversion gui client & diff/merge tool.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 3 17:43:58 2005

This is an archived mail posted to the Subversion Dev mailing list.