Re: [PATCH] wc-replacements branch: Make svn cp PATH PATH loggy

Hi Ivan!

On 9/27/05, Ivan Zhakov <chemodax@gmail.com> wrote:
> Hi!
>
> There is patch to wc-replacements branch that makes wc->wc copy loggy.
> I am posting patch to the list because I don't sure about some tricks.
> Core idea is change svn_wc_add2() to svn_wc_add_repos_file() in
> subversion/libsvn_wc/copy.c:copy_file_administratively(). Because
> svn_wc_add_repos_file() already loggy and preserves text and prop
> base. It works and passes all tests. Of course there is possible
> optimizations: make svn_wc_add_repos_file() recieve new working text
> and prop. But I consider this could be done as next step.
>
> [[
> Make svn cp PATH PATH loggy.
>
> * subversion/libsvn_wc/copy.c
> (copy_file_administratively): Use svn_wc_add_repos_file() instead of
> svn_wc_add2().
> ]]

Sorry it took me so long to review your patch.

The main problem with this patch is that it does not combine all
changes to the working copy into 1 log-file:
copy_file_administratively copies the working copy props file after
svn_wc_add_repos_file has atomically completed all other changes to
the file.

What reasons did you have not to use svn_wc_add2() - other than that
it currently isn't loggy?

In other words, wouldn't it be the better solution to make svn_wc_add2() loggy?

bye,

Erik.

PS: I'm still busy wrapping my head around the loggy-revert patch.
Received on Sun Oct 2 17:11:55 2005