[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: pre-revprop-change hook problems

From: Ximon Eighteen <ximon.eighteen_at_int.greenpeace.org>
Date: 2005-09-29 09:37:04 CEST

Madan U Sreenivasan wrote:
> On Wed, 2005-09-28 at 20:31, Michael Sinz wrote:
>> Ben Collins-Sussman wrote:
>>> That's probably because the user is performing the action anonymously.
>>> It means you've misconfigured your server -- it should be sending an
>>> authentication challenge, and it isn't.
>>>
>>> Granted, if no user is available, perhaps we should call the hook with
>>> "anonymous" as the 3rd argument, or something...? That would be
>>> inconsistent with other existing policies, though. For example, if
>>> somebody performs an anonymous commit, we don't attach a revision
>>> property of 'svn:author = anonymous' -- the svn:author property just
>>> doesn't exist on the revision.
>> Maybe it should just be "" as the 3rd argument.
> Maybe we could have parameters that are prefixed by the fieldname, like
> for instance, in a two parameter
> repos-path=/path/to/repos revision=2 author=myself propname=affectedProp
> action=A
>
> in case author is absent, it would be
> repos-path=/path/to/repos revision=2 propname=affectedProp action=A

I love this for the simple reason that it is self documenting! +1 for
3.x. From reading hacking.html it looks as though 1.4.x wouldn't be an
option because an API would change (existing hooks would break). To get
the change in earlier we could do it only for Windows platforms (bad,
requires changes to hooks that were previously portable) and/or use a
repository config option.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 29 09:40:21 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.