Re: [PATCH] Add "copied" subcommand to svnlook

On Tue, September 27, 2005 5:14 am, Peter N. Lundblad wrote:
> What about calling this option --copies instead?

No really preference here. Someone else suggested "--show-copy-info" so
that's what I did. Who's the boss here?

> We don't put spaces inside parens.

Done.

> The second column is used for property information, but luckily, there is
> a third column available to use for this + sign.

Done.

>> + if ( status[1] == '+' )
>
> (Same about spaces) And, I think it is clearer to use a flag for this
> instead of checking status, but it's a matter of taste.

This went away with the latest iteration.

> Use %ld when printf'ing a revision number.

Done.

> Why do you remove the leading slash? (And, be more generous with spaces
> around operators, please.

Just because that's how it looked in a suggestion I got earlier as to how
it should look. I'm easy either way. Who makes this kind of "preference"
call?

> Else, it looks good. Would you mind creating a basic test case for this in
> svnlook_tests.py?

Um... Never been a Python programmer and at first glance at that script,
I remember why. ;) I'll take another look and see what I can swing.

Paul
PS: updated patch attached.

-- 
Paul Dugas, Computer Engineer           Dugas Enterprises, LLC
paul@dugas.cc     phone: 404-932-1355   522 Black Canyon Park
http://dugas.cc     fax: 866-751-6494   Canton, GA 30114 USA
--
Onsite at GDOT W.Annex 404-463-2860 x199

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org