[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16244 - in trunk: . subversion/clients/cmdline subversion/include subversion/libsvn_client subversion/libsvn_wc subversion/svnversion subversion/tests/clients/cmdline subversion/tests/clients/cmdline/svntest tools/examples

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-09-26 16:09:31 CEST

Malcolm Rowe wrote:

>On Mon, Sep 26, 2005 at 03:04:10PM +0200, Branko Čibej wrote:
>
>
>>So, any suggestions? We could do away with the atomics completely _if_
>>we require single-threaded initialisation.
>>
>>
>
>From the comments added to svn_wc.h in r16270, I got the impression
>that we _were_ requiring single-threaded initialisation:
>
> * @note This function changes global (per-process) state and should,
> * to maintain consistency, be called in a single-threaded context
> * during the initialization of a Subversion client.
>
>(Obviously, that wasn't the intention, since you kept the atomic code.
>I'm just pointing out that I'd personally interpret that comment to
>mean that I shouldn't call svn_wc_set_adm_dir() from multiple threads -
>even if I were setting the same value).
>
>
The difference between "should" and "must" seems clear enough to me.

Anyway, it seems that we'll drop the CAS thing, which means I should
change that to a must. :)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 26 16:10:55 2005

This is an archived mail posted to the Subversion Dev mailing list.