Re: svn commit: r16244 - in trunk: . subversion/clients/cmdline subversion/include subversion/libsvn_client subversion/libsvn_wc subversion/svnversion subversion/tests/clients/cmdline subversion/tests/clients/cmdline/svntest tools/examples

Philip Martin wrote:

>brane@tigris.org writes:
>
>
>>+/* The name that is actually used for the WC admin directory. The
>>+ commonest case where this won't be the default is in Windows
>>+ ASP.NET development environments, which choke on ".svn". */
>>+static void *volatile adm_dir_name = DEFAULT_ADM_DIR_NAME;
>>
>>
>
>../svn/subversion/libsvn_wc/adm_files.c:55: warning: initialization discards qualifiers from pointer target type
>
>Perhaps 'static const void *volatile ...'
>
>
Hm...

>>+ const char **dir_name;
>>+ for (dir_name = valid_dir_names; *dir_name; ++dir_name)
>>+ if (0 == strcmp (name, *dir_name))
>>+ {
>>+ void *new_adm_dir_name = (void*) *dir_name;
>>+ void *old_adm_dir_name = adm_dir_name;
>>
>>
>Perhaps 'const void *' and lose the cast?
>
>
I need a cast _somewhere_ because apr_atomic_casptr takes non-const
void* parameters (and the first one has to be volatile). I'll think
about this.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 25 20:03:53 2005