[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Extending r15287 for issue #2264

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-09-22 10:35:27 CEST

On Thu, 22 Sep 2005, VK Sameer wrote:

> On Wed, 2005-09-21 at 20:55 +0200, Peter N. Lundblad wrote:
> > On Wed, 21 Sep 2005, VK Sameer wrote:
> >
> > > Attached is a much delayed patch addressing Peter Lundblad's review of
> > > r15287 - http://svn.haxx.se/dev/archive-2005-07/0352.shtml
> > >
> > I hope I can get this reviewed soon, but I don't promise anything. If
> > someone else has the time... (OTOH, it is a regression, albeit not a very
> > serious one, so getting this done would be good...)
>
> Thanks for suggesting the --force option. Even with that, I'm not sure
> this is a regression since the attached test case doesn't work using
> ra_local and the released, statically built, svn-1.2.3 executable:
>
> ./lock_tests.py -v 28
>
> ...
>
> EXPECTED STDERR:
> ACTUAL STDERR:
> svn: No lock on path '/A/B/lambda' in filesystem
> '/home/sameer/wc/svn/trunk/subversion/tests/clients/cmdline/svn-test-work/repositories/lock_tests-28/db'
> EXCEPTION: SVNLineUnequal
> FAIL: lock_tests.py 28: lock/unlock set of files, one already unlocked
>
Which means that your test case is wrong in that it doesn't account for
the error message (look at the [] in the last unlock command in the test
case). I fixed this, and then the test succeeds with 1.2.3 with ra_local.

Reviewing you rpatch now.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 22 10:36:39 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.