Re: [PATCH] Keywords as Hash 3 - libsvn_client

Ooh, careful! I think we're both being a bit too hasty here. I was just about
to commit this, and then happened to go looking at it again and noticed this error:

John Peacock wrote:
> === subversion/libsvn_client/export.c
> ==================================================================
> --- subversion/libsvn_client/export.c (/local/kwhash2) (revision 15749)
> +++ subversion/libsvn_client/export.c (/local/kwhash3) (revision 15749)
> @@ -99,7 +99,7 @@
> apr_pool_t *pool)
> {
> const svn_wc_entry_t *entry;
> - svn_subst_keywords_t kw = { 0 };
> + apr_hash_t *kw;

kw is uninitialised here.

> svn_subst_eol_style_t style;
> apr_hash_t *props;
> const char *base;
> @@ -188,14 +188,14 @@
> author = entry->cmt_author;
> }
>
> - SVN_ERR (svn_subst_build_keywords
> + SVN_ERR (svn_subst_build_keywords2
> (&kw, keywords->data,

kw is conditionally initialised here (this is in an "if" body).

> apr_psprintf (pool, fmt, entry->cmt_rev),
> entry->url, tm, author, pool));
> }
>
> - SVN_ERR (svn_subst_copy_and_translate2 (base, to, eol, FALSE,
> - &kw, TRUE,
> + SVN_ERR (svn_subst_copy_and_translate3 (base, to, eol, FALSE,
> + kw, TRUE,

kw is used here.

There may be more such cases. I'll go looking for them now (in parts 3 and 4).

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 21 21:00:57 2005