Re: [PATCH] python bindings: don't use relative imports

On 9/20/05, André Malo <nd@perlig.de> wrote:
> [[
> Don't use relative imports in the python bindings.
>
> * subversion/bindings/swig/python/svn/repos.py:
> subversion/bindings/swig/python/svn/fs.py:
> subversion/bindings/swig/python/svn/delta.py:
> subversion/bindings/swig/python/svn/wc.py:
> subversion/bindings/swig/python/svn/client.py:
> subversion/bindings/swig/python/svn/ra.py:
> import from svn.core instead just from core.
> ]]
Thanks Andre! Absolute imports are definitely easier to understand
than relative imports. Committed in r16170 with the following log
message:

[[
Upgrade Python bindings to use absolute imports instead
of relative imports, because the absolute import syntax
is easier to understand.

Patch by: Andre Malo <nd@perlig.de>
          me
(djames found and fixed a few more examples of relative
 imports)

* subversion/bindings/swig/python/svn/repos.py,
  subversion/bindings/swig/python/svn/fs.py,
  subversion/bindings/swig/python/svn/delta.py,
  subversion/bindings/swig/python/svn/wc.py,
  subversion/bindings/swig/python/svn/client.py,
  subversion/bindings/swig/python/svn/ra.py:
  Import from svn.core, svn.fs, and svn.delta
  instead of core, fs, and delta.
]]

> I hope, the log message is formatted correctly :)
Excellent work! :)

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org