On 19 Sep 2005 21:05:55 -0500, kfogel@collab.net <kfogel@collab.net> wrote:
> Ivan Zhakov <chemodax@gmail.com> writes:
> > > There's one problem with this patch: merge_tests.py 26 fails after
> > > applying it. I'm investigating why, but in case I don't resolve the
> > > issue tomorrow, I thought I'd let you know.
> >
> > Oops, on my machine it fails too. I look why is it. Seems I missed
> > that svn_wc_add_repos_file called also from merge_file_added().
>
> Ivan, you've been doing terrific work on the wc-replacements branch,
> so please don't take this comment as a condemnation:
>
> If the test fails on your machine too, then you can know that before
> posting the patch :-). In other words, always run the test suite on a
> change before posting the change. No point spending a reviewer's time
> on something that can be automatically discovered earlier.
>
> You probably came to this conclusion independently. I just wanted to
> confirm that it is standard practice for all of us.
Sorry, I am windows guy. I have unix servers, but don't use emacs and gdb :)
I have used win-tests.py, but once it stops work some reason.
Therefore I was need ran test by hand and forgot ran some of them or
forgot copy newer version of svn.exe. Now I have learnt to run
win-tests.py with directory parameter. In this case it works without
problems.
I know about practice running test suite before posting patches.
--
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 20 09:12:33 2005