Re: [PATCH] wc-replacements branch: Implement reverting after svn cp URL PATH replacements
On 9/18/05, Erik Huelsmann <email@example.com> wrote:
> On 9/14/05, Ivan Zhakov <firstname.lastname@example.org> wrote:
> > Hi, Erik and Devs!
> > [[
> > Implement reverting after svn cp URL PATH replacements.
> > * subversion/libsvn_wc/update_editor.c
> > (svn_wc_add_repos_file): Check if we're replacing the file then copy
> > text base and prop base
> > to text and prop revert file.
> > * subversion/tests/clients/cmdline/revert_tests.py
> > (revert_replacement_with_props): New helper for
> > revert_wc_to_wc_replace_with_props and
> > revert_repos_to_wc_replace_with_props.
> > (revert_wc_to_wc_replace_with_props): Renamed from
> > revert_replace_with_history_with_props. Use new helper
> > revert_replacement_with_props.
> > (revert_repos_to_wc_replace_with_props): New test of reverting svn cp URL PATH
> > replacements.
> > (test_list): Add new test revert_repos_to_wc_replace_with_props. Rename
> > revert_replace_with_history_with_props to revert_wc_to_wc_replace_with_props.
> > ]]
> Hi Ivan!
> Sorry for my late reaction, I've had a busy week.
> There's one problem with this patch: merge_tests.py 26 fails after
> applying it. I'm investigating why, but in case I don't resolve the
> issue tomorrow, I thought I'd let you know.
Oops, on my machine it fails too. I look why is it. Seems I missed
that svn_wc_add_repos_file called also from merge_file_added().
> Also, breser pointed a problem with his early work on the branch:
> He said in reaction to Philip's comment that svn_wc_add_repos_file()
> and install_file() both should probably be refactored to make 'A'dd
> loggy. I haven't looked at that yet, but maybe we can work together on
> resolving that. That's why I cc'ed him: I hope he can elaborate on the
> changes he had in mind.
Thanks, Erik for the link. Might be these refactoring should be next
step and disconnected from URL to PATH copying?
To unsubscribe, e-mail: email@example.com
For additional commands, e-mail: firstname.lastname@example.org
Received on Mon Sep 19 16:55:00 2005
This is an archived mail posted to the Subversion Dev