Re: svn commit: r16097 - in trunk/subversion: bindings/swig/perl/native include libsvn_fs libsvn_fs_base libsvn_repos tests/clients/cmdline tests/libsvn_fs

cmpilato@tigris.org writes:
> --- trunk/subversion/libsvn_repos/rev_hunt.c (original)
> +++ trunk/subversion/libsvn_repos/rev_hunt.c Fri Sep 9 04:30:51 2005
>
> @@ -442,26 +443,26 @@
> ++revision_ptr;
> }
>
> - SVN_ERR (svn_fs_revision_root (&root, fs,
> - (is_ancestor ?
> - (*revision_ptr) :
> - peg_revision), pool));
> + revision = is_ancestor ? *revision_ptr : peg_revision;
> + path = fs_path;
> if (authz_read_func)
> SVN_ERR (check_readability (root, fs_path, authz_read_func,
> authz_read_baton, pool));

As you can see, we remove the code that initializes 'root', then right
afterwards we have a conditional usage of 'root'. This is Bad :-).

Ben Collins-Sussman and Chia-Liang Kao tracked this down today. I'm a
little too tired to fix it now, but wanted y'all to know that it has
been spotted and I will fix it (unless Mike wakes up before me and
fixes it first). Note that he and I wrote that commit together, so
don't blame Mike just because the revision says 'cmpilato' on it.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 17 08:28:31 2005