[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: swig changes for svn_txdelta_apply

From: Daniel L. Rall <dlr_at_finemaltcoding.com>
Date: 2005-09-16 23:03:45 CEST

On Sat, 17 Sep 2005, Kouhei Sutou wrote:
...
> In <20050916134315.GC74254@home.clkao.org>
> "swig changes for svn_txdelta_apply" on Fri, 16 Sep 2005 21:43:15 +0800,
> Chia-liang Kao <clkao@clkao.org> wrote:
...
> > I am wondering if there's any way we can cope with the incompatibility
> > more gracefully, as I actually want the fixed behaviour as well, but
> > don't want to break existing code horribly.
...
> I'll attach a patch that recover existing Perl bindings
> svn_txdelta_apply API. If you don't agree with my approach,
> could do you apply this patch?
...
> --- subversion/bindings/swig/include/svn_types.swg (リビジョン 16142)
> +++ subversion/bindings/swig/include/svn_types.swg (作業コピー)
> @@ -499,8 +499,10 @@
> svn_txdelta_apply() uses *result_digest not digest[] .
> */
> %apply unsigned char digest[ANY] {
> - unsigned char *digest,
> - unsigned char *result_digest
> +#ifdef SWIGRUBY
> + unsigned char *result_digest,
> +#endif
> + unsigned char *digest
> };

This patch will fix the immediate problem with the Perl API incompatibility.
However, clkao raises a good question as to how to bring the Perl bindings
in line with this API in the long term, yet not break API compatibility in
the short term.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 16 23:04:48 2005

This is an archived mail posted to the Subversion Dev mailing list.