[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: [Issue 2399] svn_ra_stat returning error for non-existent path instead of NULL dirent_t*

From: William Ferguson <william_ferguson_au_at_yahoo.com>
Date: 2005-09-14 04:49:57 CEST

--- Malcolm Rowe <malcolm-svn-dev@farside.org.uk>
wrote:

> FWIW, I agree. I don't think William is particularly
> bothered about how
> this situation manifests itself, as long as it can
> be reliably identified.

I don't think that returning SVN_ERR_FS_NOT_DIRECTORY
is the appropriate response for svn_ra_stat. It
probably is for some lower-level function that is
targetting a file system, but svn_ra_stat is
targetting a logical resource path - ie there is no
reason that it needs to map down to any kind of file
system.

Not only that but SVN_ERR_FS_NOT_DIRECTORY is a bit of
a misnomer since the path that was supplied to
svn_ra_stat doesn't have to be a directory, just all
the parent paths.

I firmly believe that svn_ra_stat's reponsibility (as
currently described in the function doco) is to
clearly indicate the details of the supplied path,
which includes a NULL dirent_t* if the path does not
exist - which is the case in this scenario.

But if you decide to go with returning
SVN_ERR_FS_NOT_DIRECTORY and upgrading the doco, then
I guess I'll leave my hack in place and extend it to
all uses of svn_ra_stat just to be safe.

William

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 14 04:51:02 2005

This is an archived mail posted to the Subversion Dev mailing list.