[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [INTERM PATCH] Issue 571: A+D should be R in update

From: Christopher Ness <chris_at_nesser.org>
Date: 2005-09-13 20:09:42 CEST

On Tue, 2005-09-13 at 16:47 +0100, Philip Martin wrote:
> Christopher Ness <chris@nesser.org> writes:
>
> > * subversion/include/svn_wc.h
> > (svn_wc_notify_action_t): New enumerated type
> > svn_wc_notify_update_replace
>
> It's not a new enumerated type, it's a new value in an existing type.

Your correct, my mistake.

> Such a change may well contravene Subversion's ABI compatability
> guidelines; it's likely to break existing notification callbacks. I
> see that we added locking values to svn_wc_notify_action_t in 1.2, but
> that didn't break things in quite the same way. A 1.1 client using
> 1.2 libraries would continue to work so long as no locks were
> involved, whereas your proposed change is likely to break 1.2 clients
> using 1.3 libraries. You may need to rev the notification API.

At first I had the new value in the middle of the enumerated list which
caused the values after to be n+1 in the binary. Eric mentioned that I
was breaking binary compatibility.

In this patch the new value comes at the end of the list and therefore
all values for 1.{1,2} shall be the same as this.

Cheers,
Chris

-- 
PGP Public Key: http://www.nesser.org/pgp-key/
14:05:11 up 21:05, 2 users, load average: 0.09, 0.29, 0.23

Received on Tue Sep 13 20:10:25 2005

This is an archived mail posted to the Subversion Dev mailing list.