[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Regression test for issue 2394 (was Re: [PATCH] Fix for issue 2394 no error dialog if lock command failed)

From: John Szakmeister <john_at_szakmeister.net>
Date: 2005-09-09 12:49:17 CEST

On Friday 09 September 2005 06:46, John Szakmeister wrote:
> On Thursday 08 September 2005 19:01, Jani Averbach wrote:
> > On 2005-09-08 15:30-0700, Daniel Rall wrote:
> > > Being a perhaps a little closer to this code, I did feel comfortable
> > > making this commit. However, I completely agree with Jani that a
> > > regression test would be a good thing here.
> >
> > Sure, and that was my point. Now the fix is in the trunk and there
> > won't be any incentive to write a regression test for it and it will
> > be forgotten in about few weeks. However, it was a genuine bug and it
> > revealed a hole in the unit tests.
> >
> > My point was: Don't commit without a regression test.
> >
> > The sad thing is that I have been so hopelessly busy that I haven't
> > had time to do even that small regression test.
>
> I haven't written in Java in quite a while, but here's a patch to add a
> regression test.

BTW, I did confirm that the test fails with r16095 removed.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 9 12:49:50 2005

This is an archived mail posted to the Subversion Dev mailing list.