Re: svn commit: r16094 - trunk/subversion/libsvn_wc

dionisos@tigris.org writes:

> Author: dionisos
> Date: Thu Sep 8 16:57:26 2005
> New Revision: 16094

> --- trunk/subversion/libsvn_wc/props.h (original)
> +++ trunk/subversion/libsvn_wc/props.h Thu Sep 8 16:57:26 2005
> @@ -140,6 +140,11 @@
> svn_boolean_t recurse,
> apr_pool_t *pool);
>
> +/* Returns TRUE if any of the PROPCHANGES are the "magic" ones that
> + might require changing the working file. At present time magic props are
> + SVN_PROP_EXECUTABLE, SVN_PROP_KEYWORDS, SVN_PROP_EOL_STYLE,
> + SVN_PROP_SPECIAL, SVN_PROP_NEEDS_LOCK. */
> +svn_boolean_t svn_wc__is_magic_props_changed (apr_array_header_t *propchanges);

I don't think that's a good name for the function, or for the
parameter either. While it may happen to be called with a list of
changed properties that's just accidental, in reality it's just a list
of properties.

svn_boolean_t
svn_wc__has_magic_property (apr_array_header_t *properties)

You also need to document that the array is an array of svn_prop_t *
elements.

Listing the names of the magic properties in the comment looks a bit
odd to me: is the caller supposed to care which properties are magic?
Obviously it's a maintenance burden.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org