Re: svn:externals and spaces

On 8/31/05, Max Bowsher <maxb@ukf.net> wrote:
> Ivan Zhakov wrote:
> > Hi!
> > [[
> > Makes target directory in svn:externals property definition to be URI
> > encoded.
> >
> > * subversion/libsvn_wc/props.c
> > (svn_wc_parse_externals_description2): Decode target directory using
> > svn_path_uri_decode().
> > ]]
>
> Two major problems:
>
> 1) Compatibility. You can't just break it like that.
> 2) Very counter-intuitive for something which is definitely _not_ an URL to
> be URL-encoded.
Agreed.
I see 3 ways how spaces in externals might have be implemented:
1) Encode as URI. My current solution. Breaks compatibility if user
uses percent symbol in directory name ('%')
2) Use quotes above directory names. Breaks compatibility if system
allows using quote symbol in directory name.
3) Escape space with backslash character '\'

So, which way do you prefer?

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org