[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Reverted addition of svn_ra_create_callbacks() - svn commit: r16017

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-08-31 21:33:24 CEST

On Wed, 31 Aug 2005, [UTF-8] Branko ─^Libej wrote:

> Max Bowsher wrote:
>
> > Just a quick note to elaborate on why I reverted this change.
> >
> > Clearly, most of the change is good, we just need to discuss how to
> > get the benefits of it without introducing the circular dependencies.
> > I'd like trunk to be buildable whilst that discussion is ongoing, so I
> > backed out the changes for now.
>
> We need libsvn_ra_util, to get a diamond-like dependency tree:
>
> libsvn_ra
> |
> +-------------+--------------+
> / | \
> libsvn_ra_dav libsvn_ra_svn libsvn_ra_local
> \ | /
> +-------------+--------------+
> |
> libsvn_ra_util
>
>
> We could still expose svn_ra_create_callbacks from libsvn_ra, but it
> would only forward to the real implementation in libsvn_ra_util.
>
Extreme overkill for such a function. We don't need the constructor
internally, we just need a comment explaining why we don't use it. This
was already suggested in the thread.

Max, wouldn't it be better to ask before reverting things and give people
some time? I think David said he will fix this soon. I understand that
not be ing able to build on a particular platform is annoying, but this
reversion/recommit also adds some noise.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 31 21:35:01 2005

This is an archived mail posted to the Subversion Dev mailing list.