[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15993 - trunk/subversion/svnserve

From: David James <james82_at_gmail.com>
Date: 2005-08-30 18:47:05 CEST

On 8/30/05, Greg Hudson <ghudson@mit.edu> wrote:
> On Tue, 2005-08-30 at 11:08 -0500, kfogel@tigris.org wrote:
> > (must_have_access): Move pool to end of parameter list, as discussed
> > in review of r15982. All callers changed.
> I believe you just took a single function, which people happened to
> notice because it was touched in r15982, and made it inconsistent with
> the rest of serve.c. Didn't you notice you were doing that?
There doesn't seem to be a consistent pool parameter convention in serve.c.

(NOTE: Since these are all private functions, the SWIG bindings don't
care about them. But, it's still a good idea to use the pool as the
last argument in new functions, in case we want to make a build a
public API function with the same interface.)

Functions with pool as last argument:
- authz_check_access
- authz_check_access_cb
- authz_commit_cb
- must_have_access
- get_props
- add_lock_tokens
- unlock_paths

Functions with pool as first argument:
- lookup_access

Functions with pool as second argument:
- send_mechs
- create_fs_access
- auth
- auth_request
- trivial_auth_request
- set_path
- delete_path
- link_path
- finish_report
- abort_report
- accept_report
- write_proplist
- write_prop_diffs
- write_lock
- get_latest_rev
- get_dated_rev
- change_rev_prop
- rev_proplist
- rev_prop
- commit
- get_file

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 30 18:48:31 2005

This is an archived mail posted to the Subversion Dev mailing list.