Re: [PATCH] argument name of svn_repos_get_commit_editor3()

Kouhei Sutou <kou@cozmixng.org> writes:
> [[[
> Use same argument name as svn_repos_get_commit_editor()
> family for SWIG typemap.
>
> * subversion/include/svn_repos.c,
> subversion/include/svn_repos.h
> (svn_repos_get_commit_editor3): Remove 'commit_' prefix.
> ]]]

I didn't compile this, but assuming it compiles, +1 to commit.
(Just put "Approved by: kfogel" in the log message.)

Thanks!
-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
> Index: subversion/include/svn_repos.h
> ===================================================================
> --- subversion/include/svn_repos.h	(revision 15986)
> +++ subversion/include/svn_repos.h	(working copy)
> @@ -672,8 +672,8 @@
>                                const char *base_path,
>                                const char *user,
>                                const char *log_msg,
> -                              svn_commit_callback_t commit_callback,
> -                              void *commit_callback_baton,
> +                              svn_commit_callback_t callback,
> +                              void *callback_baton,
>                                svn_repos_authz_callback_t authz_callback,
>                                void *authz_baton,
>                                apr_pool_t *pool);
> Index: subversion/libsvn_repos/commit.c
> ===================================================================
> --- subversion/libsvn_repos/commit.c	(revision 15986)
> +++ subversion/libsvn_repos/commit.c	(working copy)
> @@ -763,8 +763,8 @@
>                                const char *base_path,
>                                const char *user,
>                                const char *log_msg,
> -                              svn_commit_callback_t commit_callback,
> -                              void *commit_callback_baton,
> +                              svn_commit_callback_t callback,
> +                              void *callback_baton,
>                                svn_repos_authz_callback_t authz_callback,
>                                void *authz_baton,
>                                apr_pool_t *pool)
> @@ -791,8 +791,8 @@
>    eb->pool = subpool;
>    eb->user = user ? apr_pstrdup (subpool, user) : NULL;
>    eb->log_msg = apr_pstrdup (subpool, log_msg);
> -  eb->commit_callback = commit_callback;
> -  eb->commit_callback_baton = commit_callback_baton;
> +  eb->commit_callback = callback;
> +  eb->commit_callback_baton = callback_baton;
>    eb->authz_callback = authz_callback;
>    eb->authz_baton = authz_baton;
>    eb->base_path = apr_pstrdup (subpool, base_path);
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
-- 
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org