[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] notification callbacks for network data transfers (V3)

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-08-28 12:56:08 CEST

Stefan Küng wrote:

> So I've got rid of those warnings. Some more files needed changes for
> this. Now I'm not sure if the log comment should be done as it is now,
> or maybe it could be shortened so that those files where the only
> changes are to use the new functions instead of the deprecated ones
> can be grouped together?

Yes, you can do that. Just make one log entry for those files that were
changed only for the open->open2 change.

> Well, just have a look at the patch and tell me what you think.

You don't have to rev the svn_ra__vtable_t::open callback. The
svn_ra__vtable_t type is private to libsvn_ra*, so you can change the
signature of the open() callback instead of revving it. It's not a
public API. :)

Otherwise, it looks fine. Please change the svn_ra__vtable_t thing and
update the log message, and I'll test and commit.

Thanks!

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 28 12:58:42 2005

This is an archived mail posted to the Subversion Dev mailing list.