[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] notification callbacks for network data transfers (V3)

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-08-28 11:33:35 CEST

Stefan Küng wrote:

> Branko Čibej wrote:
>
>> Hey Stefan, did you actually compile this patch?
>
>
> Yes, I did. I even have a small change to main.c where a simple
> printf() outputs the values of the callback.
>
>> subversion\libsvn_ra\ra_loader.c(278) : warning C4133: 'function' :
>> incompatible types - from 'const struct svn_ra_callbacks2_t *' to
>> 'const struct svn_ra_callbacks_t *'
>> subversion\libsvn_ra\ra_loader.c(304) : warning C4716: 'svn_ra_open'
>> : must return a value
>>
>> I can certainly fix this myself, but next time, please make sure you
>> don't leave thinks ilke this in the code.
>
>
> Now I feel stupid. Very sorry about this. Seems I just missed those
> warnings in all the warnings I get when compiling Subversion (there
> are really many warnings - I think I'll write a patch later to get rid
> of those).

Yah, I know about those warnings, but the easy fix (using a cast) is one
I'd like to avoid at all costs. I'll sit down one of these days and fix
the dam' thing.

> > subversion\libsvn_ra_dav\session.c(806) : warning C4090: 'function'
> : > different 'const' qualifiers
> > subversion\libsvn_ra_dav\session.c(806) : warning C4022:
> > 'ne_set_progress' : pointer mismatch for actual parameter 3
> > subversion\libsvn_ra_dav\session.c(807) : warning C4090: 'function'
> : > different 'const' qualifiers
> > subversion\libsvn_ra_dav\session.c(807) : warning C4022:
> > 'ne_set_progress' : pointer mismatch for actual parameter 3
> >
> >
> > Together with the fact that fixing the type of ra_vtable->open to
> > accept svn_ra_callbacks2_t instead of the old, deprecated type, this
> > has become more than I'm willing to "tweak". Here's the updated patch
> > and log message, the result of my tweakings. You'll have to finish
> > this yourself.
> >
> > One of the things I did is to remove the svn_progress.h header. It's
> > not needed, the progress callback typedef belongs in svn_ra.h.
>
> I'm working on it right now. Will take some time though, so stay tuned
> for the fixed patch. Maybe this afternoon.

O.K., no rush. Sorry if I sounded a bit pissed off in my last mail --
but I really don't have time to fix these issues myself.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 28 11:35:03 2005

This is an archived mail posted to the Subversion Dev mailing list.