[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15902 - trunk/tools/client-side

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-08-25 20:09:04 CEST

kfogel@tigris.org writes:

> Author: kfogel
> Date: Thu Aug 25 10:48:36 2005
> New Revision: 15902
>
> Modified:
> trunk/tools/client-side/bash_completion
>
> Log:
> * tools/client-side/bash_completion: Fix syntax errors, see issue #2387.
>
> Patch by: Nicolas Vilz <devniv@tigris.org>
> (Tweaked by me to remove some unrelated changes.)
>
>
> Modified: trunk/tools/client-side/bash_completion
> Url: http://svn.collab.net/viewcvs/svn/trunk/tools/client-side/bash_completion?rev=15902&p1=trunk/tools/client-side/bash_completion&p2=trunk/tools/client-side/bash_completion&r1=15901&r2=15902
> ==============================================================================
> --- trunk/tools/client-side/bash_completion (original)
> +++ trunk/tools/client-side/bash_completion Thu Aug 25 10:48:36 2005
> @@ -39,9 +39,9 @@
> # if not typing an option, or if the previous option required a
> # parameter, then fallback on ordinary filename expansion
> helpCmds='help|--help|h|\?'
> - if [[ ${COMP_WORDS[1]} != @($helpCmds) ]] && \
> + if [[ ${COMP_WORDS[1]} != @${helpCmds} ]] && \
> [[ "$cur" != -* ]] || \
> - [[ ${COMP_WORDS[COMP_CWORD-1]} == @($optsParam) ]] ; then
> + [[ ${COMP_WORDS[COMP_CWORD-1]} == @${optsParam} ]] ; then
> return 0
> fi
>

Those are not syntax errors, they are uses of the extended pattern
matching operator. Extended pattern matching is a bash feature that
can be enabled/disabled, if you are getting syntax errors I guess you
have it disabled. See the note at the top of the file. I don't know
what @$ means, but I'm pretty sure it doesn't work here.

I seem to recall a similar patch in the dim and distant past, perhaps
we need a comment nearer the lines in question?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 25 20:09:56 2005

This is an archived mail posted to the Subversion Dev mailing list.