On 8/25/05, Erik Huelsmann <ehuels@gmail.com> wrote:
> On 8/25/05, Erik Huelsmann <ehuels@gmail.com> wrote:
> > Hi Ivan,
> >
> > I committed this patch (with a slightly tweaked log and trailing
> > spaces) in r15897.
>
> I tweaked the log to be a bit more readable:
> - I moved the main change (adding svn_client_commit_item2_t) up
> to the top of the file list
> - I tried to reduce the size and number of individual remarks by
> * moving the APR_ARRAY_* macros to a remark at the top
> * condensing all files which have 1 - the same - remark into 1 item
> * shortening descriptions of the remaining items by not saying what was
> there, but only what you changed it to.
>
> Karl Fogel followed up my commit of your patch with a commit to end
> commit_util.c with a newline. His compiler (probably gcc) emits a
> warning when sources don't end with a newline character.
Yes, I saw these fixes. Thanks!
> I hope I clarified myself. If you have any questions, please don't
> hesitate to ask!
> Thanks for the patch and thanks for your time.
> PS: yes, I know there's another patch waiting for review. Maybe
> tonight, tomorrow otherwise: I won't be able to review earlier.
Thank you. I have a request: please merge changes from trunk to
branches/wc-replacements. I have checked it merges without conflicts.
--
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 25 10:16:17 2005