Mark Phippard <MarkP@softlanding.com> wrote on 08/23/2005 09:24:13 AM:
> Paul Burba/SoftLanding Systems wrote on 08/22/2005 06:08:56 PM:
> > Index: subversion/include/svn_wc.h
> > ===================================================================
> > --- subversion/include/svn_wc.h (revision 15823)
> > +++ subversion/include/svn_wc.h (working copy)
> > @@ -1516,6 +1516,29 @@
> > /** The entry's lock in the repository, if any. */
> > svn_lock_t *repos_lock;
> >
> > + /** Out of Date Info.
> > + *
> > + * If the working copy item is out of date compared to the
repository
> > + * the following five fields represent the HEAD state of the item
in
> > + * the repository. If not out of date, the items are set as
> described
> > + * below.
> > + */
>
> This comment has me a bit confused because of the use of the term HEAD.
I
> am assuming the information that will be passed back is about the last
> revision when the item was committed, which may or many not currently be
> the HEAD revision of the repository? Your variable names would imply
that
> is the case. Of course, this only applies to the revision number itself
> as the other values would be the same. In Subclipse, ideally we would
be
> receiving the revision number of the last commit. And this is because
we
> are using that value as a "key" to a cache variable.
Yes, the information obtained describes the last committed rev if the item
is out of date. So "HEAD" was poor word choice on my part; I was thinking
that the info returned is analogous to what's seen with,
svn info URL -r HEAD
but this is misleading at best. I'll change the comment to:
/** Out of Date Info.
*
* If a working copy item is out of date compared to the repository
* the following five fields describe the state of the last committed
* revision in the repository. If not out of date, the items are set
* as described below.
*/
Which hopefully makes the meaning clearer.
Paul B.
> > +
> > + /* If not out of date set to SVN_INVALID_REVNUM. */
> > + svn_revnum_t ood_last_cmt_rev;
> > +
> > + /* If not out of date set to 0. */
> > + apr_time_t ood_last_cmt_date;
> > +
> > + /* If not out of date set to svn_wc_status_none. */
> > + svn_node_kind_t ood_kind;
> > +
> > + /* If not out of date set to NULL. */
> > + const char *ood_url;
> > +
> > + /* If not out of date set to NULL. */
> > + const char *ood_last_cmt_author;
> > +
> > } svn_wc_status2_t;
>
> Thanks.
>
> Mark
_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 23 16:43:54 2005