Re: svn_client_commit_item_t.revision reused for different things

On 22 Aug 2005 15:11:41 -0500, kfogel@collab.net <kfogel@collab.net> wrote:
> "C. Michael Pilato" <cmpilato@collab.net> writes:
> > Ivan Zhakov <chemodax@gmail.com> writes:
> > > As comment states member revision used as base revision and
> > > copyfrom-revision, depending on copyfrom-url. For what is it? In
> > > situation replace from copy, repository need to know original file
> > > revision (for delete it) and copyfrom revision (for copy). I suggest
> > > add separate member copyfrom_rev and get rid ambiguity.
> >
> > +1. Makes sense. Knock yerself out.
> ^^^^^^^^^^^^^^^^^
>
> Ivan, I don't know how good your command of American idiom is :-). In
> case you don't know: "knock yerself out" just means "go for it".
Karl, thank you! I have spent 10 minutes for "decoding" this. Thanks
for explanations. Now I know by one American idiom more :-)
As you probably saw, I have already posted patch and waiting for
review: http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=104436

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org