[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] psvn: Bind a free variable, and mark an intentionally dynamic binding as such.

From: Kalle Olavi Niemitalo <kon_at_iki.fi>
Date: 2005-08-20 03:14:32 CEST

Erik Huelsmann <ehuels@gmail.com> writes:

> Please include xsteve@tigris.org (the author) in your next submission.
> He isn't monitoring dev@ closely.

I did when I posted the patch, but I don't think he'd care about
discussions on whether to file an issue, especially if the issue
will not be filed.

I have now committed the better changes as revision 15841.

There is still something odd about svn-parse-status-result.
It binds user-mark and user-elide to nil, and then possibly
stores (list user-mark user-elide) to ui-status. However, it
never changes user-mark and user-elide; they remain nil at all
times. Is there a hidden meaning here, or should I just remove
those variables and use (list nil nil) instead?

I'd also like to remove the ui-status variable (to eliminate the
excessive scope and the misleadingly literal initial value) and
replace its sole use with the (or ...) expression from which the
true value always comes.

  • application/pgp-signature attachment: stored
Received on Sat Aug 20 03:12:50 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.