[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ISSUE+PATCH: author & date of logentry can be empty in specific situation, problems with log.dtd & javahl

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-08-17 23:04:26 CEST

On Wed, 17 Aug 2005 kfogel@collab.net wrote:

> Michael W Thelen <mike@pietdepsi.com> writes:
> > kfogel@collab.net wrote:
> > >>Since the target of svn log is in the public zone, no credentials are
> > >>asked. Later, revision 13 & 14 alter files in the branches/1.0 folder,
> > >>which is private. Since no credentials were asked at first, svn log
> > >>cannot read these specific revisions.
> > >
> > > I don't quite understand this explanation.
> > >
> > > Whether the target of 'svn log' requires credentials or not shouldn't
> > > matter. The question is whether the *commit* (the one that resulted
> > > in the revisions being displayed) required credentials.
> >
> > I believe this is the same issue I posted about in this message:
> >
> > http://svn.haxx.se/dev/archive-2005-08/0286.shtml
> >
> > ... see Ben Collins-Sussman's response to that message for an
> > explanation of what's going on.
>
> Aaaaah, thank you. Yes, now I understand.
>
> So what's the right thing -- send back empty XML elements, or omit
> them entirely, changing the DTD to allow this?
>
Omit them. See r15631 for one way of doing it:-) (it's fun to be catching
up, I know...:-)

Also, if that hasn't been pointed out, if all paths in a revision are
unreadable, *all* revprops are cleared (including the date) are stripped.
See send_change_rev() in libsvn_repos/log.c

regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 17 23:06:06 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.