[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

need inputs on issue#443

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-08-17 12:10:58 CEST

Hi,
  Am working on svn issue #443, and am facing a problem. I thought I
could start a discussion here before I go ahead and make the changes.

A brief history of #443
Issue at:
http://subversion.tigris.org/issues/show_bug.cgi?id=443
Some discussions at:
http://svn.haxx.se/dev/archive-2005-07/0267.shtml
Latest partial patches at:
http://svn.haxx.se/dev/archive-2005-08/0115.shtml
http://svn.haxx.se/dev/archive-2005-08/0408.shtml

  Working on step 3, I feel that this step should cover introducing a
new parameter(post_commit_err) in the svn_commit_callback_t declaration.
since svn_commit_callback_t is a public declaration, this would involve
introducing new versions of the svn_commit_callback_t typedef, of the
various functions that implement this type and the API functions that
use these type/implementations.

  Quite a huge change. I would like comments on whether any alternative
ideas (other than introducing a new parameter) are possible.

  More importantly, the same set of changes are needed every time we
need to change the svn_commit_callback_t prototype. am not comfortable
with this. shouldnt it be easy to change the callback to accomodate any
new info we might need to pass on to the client in future? Any comments?

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 17 12:03:26 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.