[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_client_lock() segfaults with empty paths

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-08-16 09:44:53 CEST

On Mon, 15 Aug 2005, Stefan Küng wrote:

> Crashreport analyze time for TSVN again ;)
>
> While doing that, I found that svn_client_lock() segfaults if the first
> param (const apr_array_header_t *) contains zero elements, i.e. if no
> paths to lock are passed to the function.
>
> I know I should not call svn_client_lock() if there's nothing to lock at
> all in TSVN, so I can get rid of the crashreports I receive on my own.
> But still, I think Subversion shouldn't segfault in such a case.
>
I agree. It also follows the pattern of svn_client_mkdir2, which returns
no error on an empty targets list.

Fixed in r15734 and nominated for 1.2.x.

Thanks for the report,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 16 09:45:38 2005

This is an archived mail posted to the Subversion Dev mailing list.