On Sun, 14 Aug 2005, [UTF-8] Branko Ä^Libej wrote:
> Martin Hauner wrote:
>
> > svn diff -p file:///d:/dev/src/subcommander/preview/branches/0.1.x
> > file:///d:/dev/src/subcommander/preview/trunk
> > > M CHANGES
> >
> > # ups.. that's unexpected here. Looks like the open_file method of the
> > # diff preview editor was called.
> > -----snip---------------------------------------------------------------
> >
> >
> > Is this to be expected?
>
> Yes.
>
But is apply_text_delta() called. That's what indicates content changes.
open_file may be called for no changes at all.
> > And if so how do i recognize it so i can filter those files?
>
> The same thing "svn diff" does: compare the files. Yes, I know that
> means you have to actually download them.
>
> The only other option would be to teach the server to compare files on
> the server side. Ouch. Not before 2.0.
>
Oh, we might have to congratulate our selves; Subversion 2.0 seem to
already be released:-) See delta_files in libsvn_repos/reporter.c. If
ignore_ancestry is true, it will actually compare the file contents before
sending a text delta. And what does 2.0 have to do with this discussion?
We're not talking about moving the line-based diff to the server, as I
understand it.
(Martin, I'll take a look at your patch this week.)
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 15 18:03:51 2005