Re: svn commit: r15705 - trunk/subversion/libsvn_fs_fs

Hi,

In <200508121934.j7CJYGt09225@morbius.ch.collab.net>
  "svn commit: r15705 - trunk/subversion/libsvn_fs_fs" on Fri, 12 Aug 2005 14:34:16 -0500,
  cmpilato@tigris.org wrote:

> New Revision: 15705
>
> Log:
> Fix the fs-test 13 'delete' test failure of FSFS.
>
> * subversion/libsvn_fs_fs/fs_fs.c
> (svn_fs_fs__abort_txn): Move from revs-txns.c for access to
> fs_fs_data_t internals. Also, purge the directory cache before
> purging the transaction.

> --- trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
> +++ trunk/subversion/libsvn_fs_fs/fs_fs.c Fri Aug 12 14:34:11 2005
> @@ -2702,6 +2702,28 @@
...
> +
> +svn_error_t *
> +svn_fs_fs__abort_txn (svn_fs_txn_t *txn,
> + apr_pool_t *pool)
...
> + /* Clean out the directory cache. */
> + ffd = txn->fs->fsap_data;
> + svn_pool_clear (ffd->dir_cache_pool);
> + ffd->dir_cache_id = NULL;
...

Could you add the guard like that?:

  /* Clean out the directory cache. */
  ffd = txn->fs->fsap_data;
  if (ffd->dir_cache_id)
    {
      svn_pool_clear (ffd->dir_cache_pool);
      ffd->dir_cache_id = NULL;
    }

Now, this causes segmentation fault in Ruby bindings test
(SvnReposTest#test_transaction). In the test,
ffd->dir_cache_pool is NULL (and ffd->dir_cache_id is NULL
too).

Regards,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org