[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Issue #2291 - 'svn ls -v' should return locking information - V7

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-08-10 22:20:58 CEST

Ok, time to argue about bikeshed color. After applying a tweaked
version of the patch and running 'svn ls -v', nearly every single
filename wraps off the edge of my 80-column terminal. This is not good.

The patch does this:

            SVN_ERR (svn_cmdline_printf
- (subpool, "%7ld %-8.8s %10s %12s %s%s\n",
+ (subpool, "%7ld %-12s %10s %12s %-12s %12s %s%s\n",
                      dirent->created_rev,
                      dirent->last_author ? dirent->last_author : " ? ",
                      (dirent->kind == svn_node_file) ? sizestr : "",
                      utf8_timestr,
+ lock ? lock->owner : "",
+ lock ? utf8_lock_timestr : "",
                      utf8_entryname,
                      (dirent->kind == svn_node_dir) ? "/" : ""));

Why has the 'last author' been expanded to 12?

And I think I agree with lundblad here. There's just no room for the
lock-date, it's way too wide. I think we need to add exactly *one*
more column for the lock-author, and it should be marked in some way,
so as to distinguish it from the 'last author' field. Perhaps
something like:

      [lundblad]

   or

      *lundblad*

?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 10 22:22:13 2005

This is an archived mail posted to the Subversion Dev mailing list.