[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15653 - branches/python-bindings-improvements/build/generator

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-08-10 16:15:24 CEST

David James wrote:

>>but a) contains windows-specific stuff
>>
>>
>Really? Where? This module is cross-platform, so it needs to work on
>both Unix and Windows.
>
>
I was thinking of the *.exe tracking, and write_long_long_fix.

>>and b)
>>contains utilities (such as $PATH search??? what on earth for?)
>>
>>
>$PATH search can be useful for verifying the existence of an
>executable. We currently use this feature to double check whether the
>"apr-config" executable exists and is in your path. It's an easy
>sanity check.
>
>
And for the swig executable... but you don't need path searching for
this. You simply run the program, and if it's in $PATH, it'll work; if
it's not, it won't.

If you see a --with-foo option, then of course you don't search the
$PATH at all.

>>This is the sort of spaghetti code we've been struggling to keep out of
>>the generator. Merging this to trunk as it is now would make me very
>>uncomfortable.
>>
>>
>I'm new to the Makefile generator, so I made some newbie design
>mistakes. However, these are fortunately easy to fix. Here's my plan:
>1. Move cross-platform path-finding functionality from gen_swig.py and
>gen_win.py into a common base class, so that both Unix and Windows
>implementations can benefit. I'll call this "gen_path.py".
>2. Move SWIG file generation from gen_swig.py into a separate
>command-line utility,
>
I suggest you make this loadable as a python module as well.

> which can be called from both the Unix and the
>Windows generators and makefiles. As a side-benefit, this change will
>allow us to automatically regenerate the SWIG-wrappers for each ".h"
>header file on-the-fly when the user types "make".
>
>
O.K.

>3. Move Makefile generation from gen_swig.py into gen_make.py. After
>this, there'll be nothing left in gen_swig.py, so we can delete it.
>
>
O.K.

>Thanks for your help!
>
>
Yeah, sorry I didn't look at this earlier, but time is something other
people have. :-(

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 10 16:16:30 2005

This is an archived mail posted to the Subversion Dev mailing list.