[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15653 - branches/python-bindings-improvements/build/generator

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-08-10 11:42:28 CEST

djames@tigris.org wrote:

>Author: djames
>Date: Tue Aug 9 20:57:37 2005
>New Revision: 15653
>
>Modified:
> branches/python-bindings-improvements/build/generator/gen_swig.py
>
>Log:
>* build/generator/gen_swig.py:
> (_get_swig_version): Fallback to os.popen on Python 1.x, where os.popen3
> is not available. This workaround only works on Unix systems because it
> uses the shell to redirect stderr.
>
>
Is this really a problem? gen_win.py has a find_swig function that
unconditionally ises os.popen4 to get the swig version. Nobody ever
complained.

And wouldn't it be nice if we had _one_ function in the generator for
finding the swig version?

I've finally found time to take a quick look at the generator changes
and I'm ... worried. gen_swig.py's generator inherits from the
unix-makefile generator, but a) contains windows-specific stuff and b)
contains utilities (such as $PATH search??? what on earth for?) that, at
best, belong in a generator utilities module or in gen_base.py.

This is the sort of spaghetti code we've been struggling to keep out of
the generator. Merging this to trunk as it is now would make me very
uncomfortable.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 10 11:43:25 2005

This is an archived mail posted to the Subversion Dev mailing list.