[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FSFS failing regression tests?

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-08-09 23:36:38 CEST

On Tue, 2005-08-09 at 15:03 -0500, C. Michael Pilato wrote:
> And so, just in case the former is true, I repeat: the disallowing of
> double-deletes by svn_fs_commit_txn() only happens when some other
> user slips in a delete of something I wanted to delete *between the
> time I start my commit transaction and the time the pre-commit
> auto-merge code is run*.

I have no strong opinions about how we handle double deletes, but I
certainly agree that we should be consistent between the two cases:

  * I check out r1, perform a delete, and check it in against r2 which
already has that delete.

  * I check out r1, perform a delete, and check it in against r1; while
I'm transmitting the commit data, someone slides in a commit which also
performs the delete.

These should have the same behavior, and they don't now, and that's a
bug. Whether we modify the first case or the second case, I don't have
a preference.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 9 23:37:54 2005

This is an archived mail posted to the Subversion Dev mailing list.