Michael W Thelen <mike@pietdepsi.com> writes:
> It looks like nothing ever happened with this patch... is it all right
> if I commit this change? (I'm not sure how to assign credit for the
> patch, review, etc. since Martin wrote the original patch and this one
> is different but accomplishes the same goal.)
It looks good to me. Did you test that it works? (Don't know if it's
better to use single quotes in order to prevent $-expansion... would
someone ever *intend* for $-expansion to happen?)
For crediting, I'd do
Patch by: mthelen
Suggested by: martinto
Review by: John Peacock <jpeacock@rowman.com>
in this circumstance.
> [[[
> Surround command-line arguments with quotes when calling svn via the
> shell, so arguments with spaces are handled correctly.
>
> Patch by: Martin Tomes <lists@tomes.org>
> mthelen
> Review by: John Peacock <jpeacock@rowman.com>
>
> * contrib/client-side/svncopy.pl.in
> (SVNCall): Surround user-generated command-line options with quotes so
> they are correctly interpreted by the shell.
> ]]]
>
> ==================================================================
> --- contrib/client-side/svncopy.pl.in (revision 21885)
> +++ contrib/client-side/svncopy.pl.in (local)
> @@ -686,7 +686,7 @@
> {
> my ( $command, @options ) = @_;
>
> - my @commandline = ( $svn, $command, @svn_options, @options );
> + my @commandline = ( $svn, $command, @svn_options, map {"\"$_\""}
> @options );
>
> info( " > ", join( " ", @commandline ), "\n" );
>
> --
> Michael W Thelen
> It is a mistake to think you can solve any major problems just with
> potatoes. -- Douglas Adams
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 9 22:29:48 2005