Re: [Patch] Issue #2291 - 'svn ls -v' should return locking information - V7

Version 7 of the Patch for 'svn ls -v' should return locking information

Ben Collins-Sussman wrote:

> The svn_client_ls3() docstring needs to say that the locks hash is
> optional.
>
done.

> "form" hash? I think that's a typo. I think the docstring just
> needs to say, "same as svn_client_ls3, but always passes a NULL lock
> hash."

done

> Here's the big problem: you've defined the new function in terms of
> the old function, which is backwards. When you deprecate a function,
> it means that subversion has to stop using it absolutely everywhere.
> Our standard technique for rev'ving an API is to define the
> deprecated function in terms of the new function. So svn_client_ls2
> () should simply be a call to svn_client_ls3() with a NULL lock
> hash. And what was formerly svn_client_ls2() should be renamed to
> ls3, and extra lock features then added to it.
>
[...]

>
> ... which means there will be no need to open a new ra_session,
> right? :-)

 done.

Fix issue #2291: 'svn ls -v' should return locking information.

* subversion/include/svn_client.h
  (svn_client_ls3): New prototype.
  (svn_client_ls2): Deprecated.

* subversion/libsvn_client/ls.c
  (svn_client_ls3): Gets lock information and returns it as hash.
  (svn_client_ls2): Modified to call new function.

* subversion/clients/cmdline/ls-cmd.c
  (print_dirents): Print lock information.
  (print_dirents_xml): Print lock information in xml.

* subversion/clients/cmdline/main.c
  Mention locking information in the help text for 'svn ls'.

* subversion/clients/cmdline/dtd/list.dtd
  Updated DTD file.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org