[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14842 - trunk/subversion/clients/cmdline

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-08-08 23:23:12 CEST

Peter N. Lundblad wrote:
> On Wed, 3 Aug 2005, Julian Foad wrote:
>
>>Ping! Did this bug ever get fixed? I think the bug being discussed is that
>>when "svn lock" fails because somebody else already has the lock, it was only
>>giving a warning but should be giving an error.
>
> AFAICT, it didn't:-( I think a problematic thing is the
> SVN_ERR_IS_LOCK_ERROR macro that hardcodes which errors are non-fatal
> locking errors. That's a public macro:-(

Goodness knows how we allowed that to become a public macro. It seems to be
just a convenience for the RA layers.

Fortunately, changing the implementation of it won't break binary or source
compatibility (at least not directly, if it has been used sensibly). But
anyway, even if we can't change it, it doesn't matter because we don't have to
use it.

So that's not a problem. Would you care to propose a fix, or shall we file
this bug in the issue tracker?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 8 23:26:04 2005

This is an archived mail posted to the Subversion Dev mailing list.