[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bugs in hook scripts on Windows

From: <Edwin_Park_at_mckinsey.com>
Date: 2005-08-02 15:11:06 CEST

I am using apache, by the way.

Thanks,
Edwin

----- Original Message -----
From: Branko Čibej [brane@xbc.nu]
Sent: 08/01/2005 08:54 PM
To: Ben Collins-Sussman <sussman@collab.net>
Cc: Edwin_Park@mckinsey.com
Subject: Re: bugs in hook scripts on Windows

Ben Collins-Sussman wrote:

>
> On Jul 30, 2005, at 7:21 AM, Edwin_Park@mckinsey.com wrote:
>
>>
>> Hi,
>>
>> I discovered a few bugs in Subversion's handling of hook scripts on
>> Windows:
>>
>> * The REPOS parameter that is passed in to the batch script uses a
>> Unix-style forward slash '/' delimiter between the repository base
>> dir and the repository instead of the DOS-style backslash '\'. For
>> example, I have a repository named 'Nexus' under the 'E:\products
>> \CommonServices' directory. The REPOS parameter passed into my batch
>> script is: E:\products\CommonServices/Nexus. This has forced me to
>> resort to hardcoding the repository location in my hook scripts
>> because I cannot use the mangled path that is passed in.
>
>
> You said this is svn 1.2.0 on win2k. Which server are you using,
> apache or svnserve?
>
> Developers: is this indeed a bug?

Yes, I'd say this is a bug. We should always use the system's path
separator whenever we "display" paths to external tools ("svn diff" is
an exception because patch expects forward slashes everywhere). Hook
scripts are definitely external tools.

-- Brane

+=========================================================+
This message may contain confidential and/or privileged
information. If you are not the addressee or authorized to
receive this for the addressee, you must not use, copy,
disclose or take any action based on this message or any
information herein. If you have received this message in
error, please advise the sender immediately by reply e-mail
and delete this message. Thank you for your cooperation.
+=========================================================+

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 2 22:56:23 2005

This is an archived mail posted to the Subversion Dev mailing list.